Skip to content

Introducing OneOf and NoneOf#42

Merged
detro merged 9 commits intomainfrom
detro/one-of_none-of
Jun 23, 2022
Merged

Introducing OneOf and NoneOf#42
detro merged 9 commits intomainfrom
detro/one-of_none-of

Conversation

@detro
Copy link
Copy Markdown
Contributor

@detro detro commented Jun 21, 2022 •
edited
Loading

Closes #7
Closes #8
Closes #9

Validators added here, per package:

  • int64validator
    • OneOf(int64...), NoneOf(int64...)
  • float64validator
    • OneOf(float64...), NoneOf(float64...)
  • numbervalidator
    • OneOf(*big.Float...), NoneOf(*big.Float...)
  • stringvalidator
    • OneOf(bool, float64...), NoneOf(bool, float64...)
    • NOTE: the extra bool parameter is to enable/disable case sensitivity

The validators are designed to restrict use to the primitive types, and it will throw errors if used against any collection type.

Implementation for all but the stringvalidator package is provided by the primitivevalidator package, that holds the bulk of the logic.

@detro detro requested a review from a team as a code owner June 21, 2022 16:24
@detro detro added this to the v0.3.0 milestone Jun 21, 2022
bendbennett
bendbennett approved these changes Jun 22, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Left a comment but I'm not sure it's a significant concern.
I've only reviewed genericvalidator package as you mentioned.

Comment thread genericvalidator/acceptable_values_validator.go Outdated
@bflad bflad added the enhancement New feature or request label Jun 22, 2022
@detro detro force-pushed the detro/one-of_none-of branch from 70ac46e to 00d6c85 Compare June 22, 2022 16:38
bendbennett
bendbennett approved these changes Jun 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@bendbennett bendbennett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Couple of minor comments but nothing blocking. Guess the only question I have is around naming of the internal pkg, for instance are we going to use primitivevalidator and collectionvalidator, complexvalidator etc.

Comment thread .changelog/42.txt Outdated
Comment thread float64validator/at_least.go Outdated
Comment thread helpers/validatordiag/diag.go Outdated
Comment thread internal/primitivevalidator/acceptable_values_validator.go
Comment thread internal/primitivevalidator/none_of_test.go
@detro
Copy link
Copy Markdown
Contributor Author

detro commented Jun 23, 2022

About the internal/ package naming, I don't know what's best to do. I picked primitivevalidator just because in the FW codebase, the attr.Type implementation for them is of type primitive. And they are "Golang primitives".

For the collections, I don't have a better name 🤷 , so I'd go for something like collection*, or bunchofstuff* 😄

@detro detro force-pushed the detro/one-of_none-of branch from 9dff486 to 2fc01f4 Compare June 23, 2022 14:26
@detro detro merged commit 668b4ce into main Jun 23, 2022
@detro detro deleted the detro/one-of_none-of branch June 23, 2022 14:34
bflad added a commit that referenced this pull request Jun 29, 2022
@bflad
Update CHANGELOG for consistency with #39, #40, #41, #42, #45
b32b118
bflad added a commit that referenced this pull request Jun 29, 2022
@bflad
Update CHANGELOG for #42 to fix package name
602e5c6
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jul 24, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jul 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@bendbennett bendbennett bendbennett approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

v0.3.0

Development

Successfully merging this pull request may close these issues.

String Enumeration Validation (OneOf / NoneOf) Int64 Enumeration Validation (OneOf / NoneOf) Float64 Enumeration Validation (OneOf / NoneOf)

3 participants

@detro @bendbennett @bflad
⚡